enh(frontend) Make readiness tags scrollable#2905
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 47 minutes and 42 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe scroll container component now supports direction-aware fade masking for both horizontal and vertical scrolling. New Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
frontend/src/components/GScrollContainer.vue (1)
46-62: RenamefadeHeightto be axis-agnostic.Now that the fade supports both axes,
fadeHeightis a misnomer in the horizontal case — it actually represents the max fade length along the active axis. Consider renaming for clarity.♻️ Proposed rename
-const fadeHeight = computed(() => { +const maxFadeSize = computed(() => { const size = isVertical.value ? height.value : width.value return Math.max(40, size / 2) }) const fadeSize = computed(() => { ... - return Math.min(fadeHeight.value, Math.max(0, remaining)) + return Math.min(maxFadeSize.value, Math.max(0, remaining)) })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/src/components/GScrollContainer.vue` around lines 46 - 62, Rename the computed property fadeHeight to an axis-agnostic name (e.g., fadeLength or fadeAxisLength) and update all references accordingly: change the computed declaration from fadeHeight to the new name and replace fadeHeight.value usage inside the fadeSize computed (and anywhere else it’s used) with the new property name; ensure you keep the same logic (size = isVertical.value ? height.value : width.value, Math.max(40, size/2)) and update any template bindings or exports that referenced fadeHeight so the component compiles.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@frontend/src/components/GScrollContainer.vue`:
- Around line 46-62: Rename the computed property fadeHeight to an axis-agnostic
name (e.g., fadeLength or fadeAxisLength) and update all references accordingly:
change the computed declaration from fadeHeight to the new name and replace
fadeHeight.value usage inside the fadeSize computed (and anywhere else it’s
used) with the new property name; ensure you keep the same logic (size =
isVertical.value ? height.value : width.value, Math.max(40, size/2)) and update
any template bindings or exports that referenced fadeHeight so the component
compiles.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2c7af71b-a14f-405c-988b-2c6ada4a4023
📒 Files selected for processing (3)
frontend/src/components/GScrollContainer.vuefrontend/src/components/GSeedListRow.vuefrontend/src/components/GShootListRow.vue
1c6c1b3 to
44ef9ae
Compare
|
LGTM label has been added. DetailsGit tree hash: 09fc6dfef6fee9c7f996342d8a0a43684e1cfc34 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petersutter The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
Summary by CodeRabbit
New Features
Improvements