Add diki run script in /hack#120
Merged
dimityrmirchev merged 8 commits intogardener:mainfrom Feb 20, 2024
Merged
Conversation
gardener-robot
added
needs/review
size/M
AleksandarSavchev
force-pushed
the
create-diki-script
branch
from
0f27ee9 to
fddfd1e
Compare
Contributor
|
@dimityrmirchev You have pull request review open invite, please check |
dimityrmirchev
requested changes
Feb 16, 2024
Member
dimityrmirchev
left a comment
dimityrmirchev
left a comment
There was a problem hiding this comment.
Two small suggestions, other looks good
|
|
||
| ## Running diki Locally | ||
|
|
||
| This document will walk you through running Diki against a local shoot cluster for development purposes. This guide uses the Gardener's local development setup. |
Member
There was a problem hiding this comment.
Suggested change
| This document will walk you through running Diki against a local shoot cluster for development purposes. This guide uses the Gardener's local development setup. | |
| This part will walk you through the process of running Diki against a local shoot cluster for development purposes. This guide uses the Gardener's local development setup. |
|
|
||
| If you install via GitHub releases, you need to put the diki binary on your path. | ||
|
|
||
| You can also install diki using this code snippet: |
Member
There was a problem hiding this comment.
Suggested change
| You can also install diki using this code snippet: | |
| A sample install snippet for macOS can look like this: |
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds diki run script in
/hack. The purpose of the script is to ease the use ofdiki. The main improvements are a comprehensive--helpmessage and defaultldflagsflags.Which issue(s) this PR fixes:
Fixes #118
Special notes for your reviewer:
Release note: