Add output flag to diki run#194
Merged
dimityrmirchev merged 4 commits intogardener:mainfrom Mar 26, 2024
Merged
Conversation
gardener-robot
added
needs/review
size/S
ghost
added
AleksandarSavchev
changed the title
dimityrmirchev
requested changes
Mar 26, 2024
|
|
||
| - Run all known rulesets for all known providers and create a summary json report file | ||
| ```bash | ||
| diki run --config=config.yaml --all --output=/tmp/report.json |
Member
There was a problem hiding this comment.
Suggested change
| diki run --config=config.yaml --all --output=/tmp/report.json | |
| diki run --config=config.yaml --all --output=./report.json |
| } | ||
|
|
||
| func addRunFlags(cmd *cobra.Command, opts *runOptions) { | ||
| cmd.PersistentFlags().StringVar(&opts.outputPath, "output", "", "If set diki creates an summary json report at the given path.") |
Member
There was a problem hiding this comment.
Suggested change
| cmd.PersistentFlags().StringVar(&opts.outputPath, "output", "", "If set diki creates an summary json report at the given path.") | |
| cmd.PersistentFlags().StringVar(&opts.outputPath, "output", "", "If set diki writes a summary json report to the given file path.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: