Improve provider meta sorting#37
Merged
dimityrmirchev merged 2 commits intogardener:mainfrom Oct 4, 2023
Merged
Conversation
gardener-robot
added
needs/review
size/XS
ghost
added
the
AleksandarSavchev
requested changes
Oct 4, 2023
Member
AleksandarSavchev
left a comment
AleksandarSavchev
left a comment
There was a problem hiding this comment.
Thanks for the PR! One minor nit.
Comment on lines
62
to
65
| {{ $meta := MergedMetadataTexts . }} | ||
| {{ $keys := SortedMapKeys $meta }} | ||
| {{ range $id := $keys }}<li><span class="font-bold">{{ $id }}</span> {{ index $meta $id }}</li> | ||
| {{ end }} |
Member
There was a problem hiding this comment.
Suggested change
| {{ $meta := MergedMetadataTexts . }} | |
| {{ $keys := SortedMapKeys $meta }} | |
| {{ range $id := $keys }}<li><span class="font-bold">{{ $id }}</span> {{ index $meta $id }}</li> | |
| {{ end }} | |
| {{- $meta := MergedMetadataTexts . }} | |
| {{- $keys := SortedMapKeys $meta }} | |
| {{- range $id := $keys }} | |
| <li><span class="font-bold">{{ $id }}</span> {{ index $meta $id }}</li> | |
| {{- end }} |
Use dash to remove unnecessary new lines from report.
Comment on lines
62
to
65
| {{ $keys := SortedMapKeys .Metadata }} | ||
| {{ $meta := .Metadata }} | ||
| {{ range $key := $keys }}<li><span class="font-semibold">{{ $key }}</span>: {{ index $meta $key }}</li> | ||
| {{ end }} |
Member
There was a problem hiding this comment.
Suggested change
| {{ $keys := SortedMapKeys .Metadata }} | |
| {{ $meta := .Metadata }} | |
| {{ range $key := $keys }}<li><span class="font-semibold">{{ $key }}</span>: {{ index $meta $key }}</li> | |
| {{ end }} | |
| {{- $keys := SortedMapKeys .Metadata }} | |
| {{- $meta := .Metadata }} | |
| {{- range $key := $keys }} | |
| <li><span class="font-semibold">{{ $key }}</span>: {{ index $meta $key }}</li> | |
| {{- end }} |
Same as above.
gardener-robot
added
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sorts the metadata keys and providers in order to generate more consistent reports.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: