pod-files checks only files with paths part of the volumeMounts of the container#39
Merged
dimityrmirchev merged 3 commits intogardener:mainfrom Oct 4, 2023
Conversation
gardener-robot
added
needs/review
size/S
ghost
added
gardener-robot
added
size/M
dimityrmirchev
requested changes
Oct 4, 2023
Member
dimityrmirchev
left a comment
dimityrmirchev
left a comment
There was a problem hiding this comment.
Just one minor suggestion
|
|
||
| func (r *RulePodFiles) isMountRequiredByContainer(destination, containerName string, pod *corev1.Pod) bool { | ||
| for _, container := range pod.Spec.Containers { | ||
| if container.Name == containerName { |
Member
There was a problem hiding this comment.
We can reduce nesting if we continue when the names do not match like in the function below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: