[Kubernetes STIG v1r10] 242415 rule: add new option to select pods to accept#61
Merged
dimityrmirchev merged 3 commits intogardener:mainfrom Nov 20, 2023
Merged
Conversation
gardener-robot
added
needs/review
size/M
dimityrmirchev
requested changes
Nov 20, 2023
| passed := true | ||
| for _, container := range pod.Spec.Containers { | ||
| if container.Ports != nil && container.Env != nil { | ||
| if container.Env != nil { |
Member
There was a problem hiding this comment.
I think that this check is not necessary since range over nil will not panic.
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: