Skip to content

[Kubernetes STIG v1r11] Add support for ruleset#65

Merged
dimityrmirchev merged 7 commits intogardener:mainfrom
dimityrmirchev:v1r11
Nov 27, 2023
Merged

[Kubernetes STIG v1r11] Add support for ruleset#65
dimityrmirchev merged 7 commits intogardener:mainfrom
dimityrmirchev:v1r11

Conversation

@dimityrmirchev
Copy link
Copy Markdown
Member

@dimityrmirchev dimityrmirchev commented Nov 27, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #63

Special notes for your reviewer:

Release note:

Diki now supports DISA Kubernetes STIG version `v1r11`.

@dimityrmirchev dimityrmirchev requested a review from a team as a code owner November 27, 2023 11:35
@gardener-robot gardener-robot added needs/review size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 27, 2023
Copy link
Copy Markdown
Member

@AleksandarSavchev AleksandarSavchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just 1 request.

Rule 242401 is a duplicate of rule 242461. Currently we skip rule 242461 ref. Can you please add the implementation of rule 242461?

@dimityrmirchev
Copy link
Copy Markdown
Member Author

Nice catch. And I guess 242435 was a duplicate of 242382.

Copy link
Copy Markdown
Member

@AleksandarSavchev AleksandarSavchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support V1R11 of Kubernetes STIG

5 participants