Virtual Garden Provider implementation#71
Merged
dimityrmirchev merged 6 commits intogardener:mainfrom Nov 29, 2023
Merged
Conversation
gardener-robot
added
needs/review
size/XL
ghost
added
AleksandarSavchev
requested changes
Nov 29, 2023
Member
AleksandarSavchev
left a comment
AleksandarSavchev
left a comment
There was a problem hiding this comment.
I think we should move the shared dir into pkg/provider/shared. WDYT?
Member
Author
I addd a |
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements the basics of a virtual garden provider. It also shares the
242376rule logic between providers. Par of #68Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
We should also extend the new version script https://github.com/gardener/diki/blob/main/hack/gen-new-disak8sstig-version.sh but that can be done in another PR.
Release note: