Skip to content

Comments

Remove duplicated pages to improve search results#840

Merged
marc1404 merged 5 commits intogardener:masterfrom
marc1404:docs/720-remove-duplicates
Feb 9, 2026
Merged

Remove duplicated pages to improve search results#840
marc1404 merged 5 commits intogardener:masterfrom
marc1404:docs/720-remove-duplicates

Conversation

@marc1404
Copy link
Member

@marc1404 marc1404 commented Feb 6, 2026

How to categorize this PR?

/kind cleanup enhancement task

What this PR does / why we need it:

In the Docforge configuration, certain files are "hand-picked" to replicate them in relevant, accessible locations such as the Guides or Security and Compliance section. However, since the replicated file remains at its original location (usually specified via the fileTree directive in Docforge), the content is effectively duplicated.
This leads to duplicate search results for certain queries targeting these pages.

This PR does the following:

  • Explicitly excludes hand-picked files in their original location (where they're included through fileTree).
  • Removes 3 duplicates where their original location is the semantically better place for the page to appear in.

Which issue(s) this PR fixes:
Fixes #720

Special notes for your reviewer:

It might be easier to review the changes by browsing the individual commits.

/cc @n-boshnakov @BoHristova @klocke-io

ℹ️ @LibenHailu, thank you for figuring out the root cause issue!

@marc1404 marc1404 requested a review from a team as a code owner February 6, 2026 15:10
@gardener-prow gardener-prow bot added the kind/cleanup Something that is not needed anymore and can be cleaned up label Feb 6, 2026
@netlify
Copy link

netlify bot commented Feb 6, 2026

Deploy Preview for soon-to-be-gardenercloud failed.

Name Link
🔨 Latest commit 16f3106
🔍 Latest deploy log https://app.netlify.com/projects/soon-to-be-gardenercloud/deploys/6986044bfc942f0007ed1c47

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension kind/task General task cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2026
@gardener-github-actions gardener-github-actions bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 6, 2026
@github-actions github-actions bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 6, 2026
@gardener-github-actions gardener-github-actions bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 6, 2026
@github-actions github-actions bot removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 6, 2026
Comment on lines -51 to +56
title: Provider Alicloud
title: Provider Alibaba Cloud
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated scout rule change

Comment on lines -66 to +71
title: Provider Openstack
title: Provider OpenStack
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated scout rule change

@gardener-robot
Copy link

@BoHristova, @klocke-io, @n-boshnakov You have pull request review open invite, please check

- file: _index.md
frontmatter:
title: High Availability
weight: 30
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only contains 2 files that are excluded below. Therefore, we don't need the directory when the files are shown in the Guides section instead.

Comment on lines -233 to -240
- dir: code
structure:
- dir: security-guide
structure:
- file: _index.md
frontmatter:
title: Security Release Process
source: https://github.com/gardener/.github/blob/main/SECURITY.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already included here:

source: https://github.com/gardener/.github/blob/main/SECURITY.md

We should not have the page twice.

Comment on lines -17 to -21
- file: api-reference.md
frontmatter:
title: API Reference
persona: Developers
source: https://github.com/gardener/etcd-druid-api/blob/main/docs/api-reference/druid.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already included through the fileTree option directly below

Comment on lines -8 to -11
- file: /website/documentation/getting-started/features/credential-rotation.md
frontmatter:
title: Credential Rotation
weight: 37
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already included through the fileTree option on getting-started:

- fileTree: /website/documentation/getting-started

@BoHristova
Copy link
Contributor

Thank you :)

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 9, 2026

LGTM label has been added.

DetailsGit tree hash: 53bfa749fbf05c9c34a24b22c6e0d2afc75d5f9f

Copy link
Contributor

@n-boshnakov n-boshnakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested locally, everything seems to work fine.

@gardener-prow
Copy link

gardener-prow bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n-boshnakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2026
@marc1404 marc1404 merged commit 6351d73 into gardener:master Feb 9, 2026
21 of 27 checks passed
@marc1404 marc1404 deleted the docs/720-remove-duplicates branch February 9, 2026 10:43
@marc1404 marc1404 mentioned this pull request Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up kind/enhancement Enhancement, improvement, extension kind/task General task lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search results are duplicated

4 participants