Skip to content

Conversation

@marc1404
Copy link
Member

@marc1404 marc1404 commented Feb 9, 2026

How to categorize this PR?

/kind bug cleanup

What this PR does / why we need it:

Main motivation:

  • Using the correct Make target in the PR preview workflow.

Other changes:

  • Removed the scripts section in the package.json. This is a bit opinionated, but it doesn't add value if it's just redirecting to Make targets anyway.
  • Fixed the Docker build and documented the correct Make target for running the Docker preview.
  • Pinned the dependencies in the package.json. This is a Node.js best practice.

Which issue(s) this PR fixes:

n.a.

Special notes for your reviewer:

/cc @klocke-io

@marc1404 marc1404 requested a review from a team as a code owner February 9, 2026 13:53
@gardener-prow gardener-prow bot requested a review from klocke-io February 9, 2026 13:53
@gardener-prow gardener-prow bot added kind/bug Bug kind/cleanup Something that is not needed anymore and can be cleaned up labels Feb 9, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign klocke-io for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 9, 2026
@gardener-github-actions gardener-github-actions bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 9, 2026
@github-actions github-actions bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 9, 2026
@BoHristova
Copy link
Contributor

Thank you! Just today, I was struggling to understand why make docker-preview doesn't work for me, and @klocke-io suggested some of the changes included in this PR. I was about to open a PR myself when I saw that you had already fixed the issue, updated the README, and even went the extra mile. Great work!

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 9, 2026

LGTM label has been added.

DetailsGit tree hash: e66ac717b48b14b085d46aba4b5859d1328b8c0f

@marc1404
Copy link
Member Author

Merging to fix the documentation build & deploy.

@marc1404 marc1404 merged commit e94775a into gardener:master Feb 10, 2026
14 of 15 checks passed
@marc1404 marc1404 deleted the fix/make-targets branch February 10, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants