refactor imperative "watering schedule" to declarative "soil humidity…#845
refactor imperative "watering schedule" to declarative "soil humidity…#845marc1404 merged 2 commits intogardener:masterfrom
Conversation
… requirement" Plus it's fact-checked https://www.aos.org/orchid-care/humidity-for-plants
|
Welcome @revdarragh! |
marc1404
left a comment
There was a problem hiding this comment.
Love the attention to detail here and the care for precious orchids! 🫶
I'll leave it up to @hendrikKahl to decide whether he wants to adjust the image for scene 4 accordingly:
https://github.com/revdarragh/documentation/blob/master/website/documentation/getting-started/images/podrick/scene-4.png
|
@revdarragh, could you sign the contributor license agreement (CLA)? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marc1404 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 7218ff4e4867248dbd15dd261ea0920cb24f07b8 |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughA single line in the getting-started documentation was updated, replacing watering frequency guidance with soil humidity range specifications for the Podrick's Orchid Patch section. This is a documentation content modification with no code or structural changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
… requirement"
Plus it's fact-checked https://www.aos.org/orchid-care/humidity-for-plants
How to categorize this PR?
/kind cleanup
What this PR does / why we need it:
Small tweak to the Podrick story. Imperative/declarative is a big mindset change that is core to the technology strategy/approach. I believe it can be a difficult mindset switch to make for some. The metaphor of this "declared intent for the plot" is central to the narrative of the story, so I felt it was important to make sure it's as clean as possible.
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
Summary by CodeRabbit