-
Notifications
You must be signed in to change notification settings - Fork 90
Include Gardener Enhancement Proposals (GEPs) through Docforge #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8fcc167 to
fcc48e7
Compare
🚀 Preview DeployedYour preview is being built and will be available at: Note: The preview will only be available after the GitHub Pages deployment completes in the demo repository. To view the deployment status, visit: https://github.com/gardener/documentation-demo/actions |
📝 WalkthroughWalkthroughThe pull request updates the documentation configuration file to adjust the weight of the security-and-compliance section and introduces a new proposals section with its index file and associated file tree mappings. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
| title: Security and Compliance | ||
| description: Make sure that your clusters are compliant and secure | ||
| weight: 30 | ||
| weight: 36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gardener directory below already has weight: 30, I want to sort the proposals below "Gardener" and above "Security and Compliance".
rfranzke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
LGTM label has been added. DetailsGit tree hash: e95380faf81108b46d1f6153548d7717ab92c1e6 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Includes the Gardener Enhancement Proposals (GEPs) through Docforge.
Which issue(s) this PR fixes:
n.a.
Special notes for your reviewer:
/cc @rfranzke
Note
The rendered titles of the enhancement proposals in the sidebar are not ideal yet. The source files no longer contain a frontmatter section with a
titlefield. Instead, the information is kept in a separategep.yamlnext to the proposal (similar to thekep.yamlfiles in Kubernetes). In a next step, we could implment a Docforge plugin that builds the frontmatter information based on agep.yamlfile (if present).Summary by CodeRabbit
Release Notes