Skip to content

Introduce pool member collection task.#594

Merged
Bobi-Wan merged 3 commits intogardener:mainfrom
Bobi-Wan:fix/openstack-pool-task-break-down
Aug 13, 2025
Merged

Introduce pool member collection task.#594
Bobi-Wan merged 3 commits intogardener:mainfrom
Bobi-Wan:fix/openstack-pool-task-break-down

Conversation

@Bobi-Wan
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Current OpenStack pool collection task takes a lot of time.
I thought that by splitting collection for pool members to be in a separate task (one per pool entry),
the average task duration would drop. This doesn't seem to be the case, since pool member collection still takes up to ~9 seconds for resources on the dev environment. Mostly due to pools.ListMembers, which I don't think I can split further.
Still, this approach helps spread the load across multiple tasks, lowering the wait. Also, we now have metrics for pool members, which we didn't have before.

I haven't added a pool member dashboard panel yet.

Release note:

Collect OpenStack pool members in a separate task

@Bobi-Wan Bobi-Wan requested a review from a team as a code owner August 12, 2025 14:10
@gardener-robot gardener-robot added needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2025
split the current pool + member collection task into one task per pool member group
@Bobi-Wan Bobi-Wan force-pushed the fix/openstack-pool-task-break-down branch from eabf440 to ce31731 Compare August 12, 2025 14:36
Comment thread pkg/openstack/tasks/pools.go
Comment thread pkg/openstack/tasks/pools.go
Comment thread pkg/openstack/tasks/metrics.go Outdated
Copy link
Copy Markdown
Member

@dnaeon dnaeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 13, 2025
@Bobi-Wan Bobi-Wan merged commit 16a2bcd into gardener:main Aug 13, 2025
4 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 13, 2025
@Bobi-Wan Bobi-Wan deleted the fix/openstack-pool-task-break-down branch January 7, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed/lgtm Has approval for merging size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants