Introduce pool member collection task.#594
Merged
Bobi-Wan merged 3 commits intogardener:mainfrom Aug 13, 2025
Merged
Conversation
split the current pool + member collection task into one task per pool member group
eabf440 to
ce31731
Compare
dnaeon
reviewed
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Current OpenStack pool collection task takes a lot of time.
I thought that by splitting collection for pool members to be in a separate task (one per pool entry),
the average task duration would drop. This doesn't seem to be the case, since pool member collection still takes up to ~9 seconds for resources on the dev environment. Mostly due to pools.ListMembers, which I don't think I can split further.
Still, this approach helps spread the load across multiple tasks, lowering the wait. Also, we now have metrics for pool members, which we didn't have before.
I haven't added a pool member dashboard panel yet.
Release note: