Merged
Conversation
add vpc dhcp_option_set_id column to vpc model
…ion sets. add metric description for DHCP option sets. Register the task handler
gardener-robot
added
size/L
Bobi-Wan
force-pushed
the
feat/aws-dhcp-option-sets
branch
from
6e2ce31 to
ffafa88
Compare
aws dhcp optionsets aws vpcs openstack pools
dnaeon
requested changes
Sep 16, 2025
gardener-robot
added
reviewed/lgtm
gardener-robot
added
the
status/closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the following changes to AWS models:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Not all DHCP option set information has been persisted. For example, tags and specific configurations, which are also dynamic (key-value strings) aren't collected, as they aren't needed for determining orphan resources. They can be added on a later iteration if needed.
Release note: