Skip to content

Fix provider_type logic in Gardener DNS objects#688

Merged
Bobi-Wan merged 9 commits intogardener:mainfrom
Bobi-Wan:fix/gardener-dns
Nov 10, 2025
Merged

Fix provider_type logic in Gardener DNS objects#688
Bobi-Wan merged 9 commits intogardener:mainfrom
Bobi-Wan:fix/gardener-dns

Conversation

@Bobi-Wan
Copy link
Copy Markdown
Contributor

@Bobi-Wan Bobi-Wan commented Nov 7, 2025

What this PR does / why we need it:
Adds provider_type field for DNSRecord objects and updates

  • g_dns_object view - propagates provider_type, as g_dns_entry already has the field
  • aws_orphan_dns_record view: filters on g_dns_object.provider_type being 'aws-route-53' or 'remote'. The latter points to a cluster-local dns proxy that caches route-53 records, so it's also mapped to AWS records.

Updates dashboards for gardener, aws, orphan aws resources with useful information (including orphan DHCP option set, which was missing before).

Minor updates:

  • missing "g:model:cloud_profile_openstack_image" model registration
  • rename gardener/tasks/bastion.go -> bastions.go for consistency

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
g_dns_object view down migration looks complex, because dropping view columns is a pain in Postgres.
The view has to be recreated and so all tables referencing it need to be dropped before and recreated after.

Release note:

ProviderType field in Gardener DNSRecord model. Better filtering for orphan resources.
DNS related panels in various dashboards.

@Bobi-Wan Bobi-Wan requested a review from a team as a code owner November 7, 2025 12:51
@gardener-robot gardener-robot added needs/review Needs review size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Nov 7, 2025
Comment thread pkg/gardener/models/models.go
Copy link
Copy Markdown
Member

@dnaeon dnaeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 9, 2025
@Bobi-Wan Bobi-Wan merged commit f8fad55 into gardener:main Nov 10, 2025
4 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 10, 2025
@Bobi-Wan Bobi-Wan deleted the fix/gardener-dns branch January 7, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewed/lgtm Has approval for merging size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants