Merged
Conversation
Collaborator
Author
|
/kind enhancement |
f0ccd0d to
4369594
Compare
Collaborator
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nickytd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind cleanup
/area logging
What this PR does / why we need it:
This PR simplifies the behavior when no client/destination is found for a log record. Previously, the plugin would return an error (unless the OpenTelemetry Collector watch mode was enabled, in which case it would silently drop the record). Now, regardless of configuration, records without a matching destination are simply dropped (returning
nil) instead of propagating an error. This removes the inconsistent conditional logic and the now-unusedfmtimport.Code changes:
WatchOpenTelemetryCollectorin the "no client found" branch.fmt.Errorf(...)error return with a simplereturn nil, unconditionally dropping records that have no matching destination."fmt"import as it is no longer needed.Additional context:
The dropped log metric (
metrics.DroppedLogs) with theno_clientlabel is still incremented, so observability of dropped records is preserved.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
The behavioral change means that records without a destination will now always be silently dropped rather than causing an error to be returned to Fluent Bit. Reviewers should confirm this is the intended behavior for all configurations, not just OpenTelemetry Collector mode.
Release note:
📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!
PR Bot Information
Version:
1.18.11| 📖 Documentation | 🚨 Create Incident | 💬 Feedback26b95500-22d3-11f1-9506-c4ba97815e4aanthropic--claude-4.6-sonnetpull_request.opened