Skip to content

Add lastError and lastOperation to Terminal status#281

Merged
petersutter merged 16 commits intomasterfrom
enh/terminal-status
Apr 18, 2024
Merged

Add lastError and lastOperation to Terminal status#281
petersutter merged 16 commits intomasterfrom
enh/terminal-status

Conversation

@petersutter
Copy link
Copy Markdown
Member

@petersutter petersutter commented Apr 11, 2024 •
edited
Loading

What this PR does / why we need it:
Add lastError and lastOperation to Terminal status.
When reconciling the Terminal resource, Terminal.status.lastError and Terminal.status.lastOperation is now updated.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

When reconciling the `Terminal` resource, `Terminal.status.lastError` and `Terminal.status.lastOperation` is now updated.

@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 11, 2024
@gardener-robot gardener-robot added needs/review Needs review size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Apr 11, 2024
@petersutter petersutter force-pushed the enh/terminal-status branch from 0b8a59b to b3556c4 Compare April 11, 2024 20:49
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 11, 2024
@petersutter petersutter force-pushed the enh/terminal-status branch from 5b46e27 to faf9613 Compare April 11, 2024 21:15
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 11, 2024
@petersutter petersutter force-pushed the enh/terminal-status branch from faf9613 to 418c66a Compare April 12, 2024 08:29
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 12, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 12, 2024
@petersutter petersutter force-pushed the enh/terminal-status branch from 264bfc0 to 2c5b229 Compare April 12, 2024 13:00
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 12, 2024
@gardener-robot gardener-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 12, 2024
@petersutter petersutter mentioned this pull request Apr 12, 2024
Merged
@gardener-robot
Copy link
Copy Markdown

gardener-robot commented Apr 14, 2024

@holgerkoser, @grolu You have pull request review open invite, please check

@petersutter petersutter changed the title AddlastOperation to Terminal status Add lastError and lastOperation to Terminal status Apr 16, 2024
holgerkoser
holgerkoser approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Apr 16, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 16, 2024
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Apr 17, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 17, 2024
grolu
grolu approved these changes Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Apr 18, 2024
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 18, 2024
@petersutter petersutter merged commit 79766b7 into master Apr 18, 2024
@petersutter petersutter deleted the enh/terminal-status branch April 18, 2024 15:13
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 18, 2024
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

Assignees

No one assigned

Labels

area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@petersutter @gardener-robot @holgerkoser @grolu @gardener-robot-ci-1 @gardener-robot-ci-2