Update the component name from terminal to terminal-controller-manager#294
Merged
petersutter merged 1 commit intogardener:masterfrom May 14, 2024
Merged
Conversation
gardener-robot
added
needs/review
gardener-robot-ci-2
added
reviewed/ok-to-test
ialidzhikov
requested review from
grolu,
holgerkoser and
petersutter
as code owners
|
@holgerkoser, @grolu You have pull request review open invite, please check |
gardener-robot
added
the
status/closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Long story short, the internal CI/CD system has some issues when the image name in an
images.yamlfile differs from the component name of the component.Starting v1.94.0 gardener-operator manages the terminal-controller-manager and the image name there is
terminal-controller-manager: https://github.com/gardener/gardener/blob/v1.94.0/imagevector/images.yaml#L47-L50Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note: