Drop credential.secretRef from Terminal#320
Merged
petersutter merged 2 commits intomasterfrom Sep 26, 2024
Merged
Conversation
credential.secretRefcredential.secretRef from Terminal
Merged
This was referenced May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the
credential.secretRefproperty from both the terminal host and target properties. This feature was originally used for:Seed's kubeconfig. However, thespec.secretReffield has been removed from theSeedAPI in g/g without replacement.Shoot's static token kubeconfig, which was stored as a<shootname>.kubeconfigSecret(for Kubernetes versions below 1.27). With the availability of theshoot/adminkubeconfigAPI to request admin kubeconfigs forShootclusters, referencing the static token kubeconfigSecretis no longer necessary.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: