Skip to content

Drop credential.secretRef from Terminal#320

Merged
petersutter merged 2 commits intomasterfrom
drop-secretRef
Sep 26, 2024
Merged

Drop credential.secretRef from Terminal#320
petersutter merged 2 commits intomasterfrom
drop-secretRef

Conversation

@petersutter
Copy link
Copy Markdown
Member

What this PR does / why we need it:
This PR removes the credential.secretRef property from both the terminal host and target properties. This feature was originally used for:

  • Referencing the Seed's kubeconfig. However, the spec.secretRef field has been removed from the Seed API in g/g without replacement.
  • Referencing the Shoot's static token kubeconfig, which was stored as a <shootname>.kubeconfig Secret (for Kubernetes versions below 1.27). With the availability of the shoot/adminkubeconfig API to request admin kubeconfigs for Shoot clusters, referencing the static token kubeconfig Secret is no longer necessary.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `credential.secretRef` property has been removed from the terminal `host` and `target` properties:
- For `Seed` resources, `spec.secretRef` was removed from the API without replacement, eliminating the need for `credential.secretRef`.
- For `Shoot` resources, `credential.shootRef` now replaces the previously used `credential.secretRef` for static token kubeconfigs.

@gardener-robot gardener-robot added needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 23, 2024
@petersutter petersutter changed the title Drop credential.secretRef Drop credential.secretRef from Terminal Sep 24, 2024
Copy link
Copy Markdown
Member

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 24, 2024
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 24, 2024
Copy link
Copy Markdown
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter merged commit 8fd08b1 into master Sep 26, 2024
@petersutter petersutter deleted the drop-secretRef branch September 26, 2024 08:52
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 26, 2024
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Oct 14, 2024
@petersutter petersutter mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants