Add python3-yaml to the machine descriptions in the Dockerfile.#110
Merged
JoshuaWatt merged 3 commits intogarmin:masterfrom Oct 3, 2025
Merged
Conversation
The AMD/Xilinx gen-machineconf script needs yaml. Signed-off-by: Philip Balister <philip@balister.org>
JoshuaWatt
previously requested changes
Oct 3, 2025
| lzo-dev \ | ||
| musl-utils \ | ||
| openssl-dev \ | ||
| python3-yaml \ |
Collaborator
There was a problem hiding this comment.
This one is not needed. This container builds a icecc (which I should probably just remove at this point), which is then imported into the other container builds
| ncurses-term \ | ||
| python \ | ||
| python3 \ | ||
| python3-yaml \ |
Collaborator
There was a problem hiding this comment.
Sorry, I was unclear: The -base images do not need this, please remove
| ncurses-term \ | ||
| python \ | ||
| python3 \ | ||
| python3-yaml \ |
| ncurses-term \ | ||
| python \ | ||
| python3 \ | ||
| python3-yaml \ |
| ncurses-term \ | ||
| python \ | ||
| python3 \ | ||
| python3-yaml \ |
| cpio \ | ||
| python \ | ||
| python3 \ | ||
| python3-yaml \ |
Collaborator
There was a problem hiding this comment.
Add a comment like "Required for 3rd party scripts" or similar and move down to like 494
| cpio \ | ||
| python \ | ||
| python3 \ | ||
| python3-yaml \ |
| cpio \ | ||
| python \ | ||
| python3 \ | ||
| python3-yaml \ |
| socat \ | ||
| cpio \ | ||
| python3 \ | ||
| python3-yaml \ |
| socat \ | ||
| cpio \ | ||
| python3 \ | ||
| python3-yaml \ |
Signed-off-by: Philip Balister <philip@balister.org>
Fix up installation of dependencies
JoshuaWatt
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AMD/Xilinx gen-machineconf script needs yaml.