fix(gstack-config): accept @local endpoint ids for brain_trust_policy - #2222
Merged
16francej merged 1 commit intoJul 14, 2026
Merged
Conversation
endpoint-hash returns "local" for stdio/PGLite, but validators only allowed hex suffixes, so setup-gbrain could not persist trust policy. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
endpoint-hashreturns the literallocalfor stdio/PGLite engines, but key validation only allowed@[a-f0-9]+, so/setup-gbrainStep 9.5 and/sync-gbraincould not persistbrain_trust_policy@local.@suffix to alphanumeric endpoint ids (hex hashes +local) in get/set validators and lookup.@localaccept and punctuation reject; fixuser_slug_at_localpersist assertion.Fixes #2210
Fixes #1988
Test plan
bun test browse/test/gstack-config.test.tsbun test test/user-slug-fallback.test.tsset brain_trust_policy@local; fixed binary persistspersonalgbrain put/search → policy persist with YC OpenAI keyMade with Cursor