fix(ship): point design-checklist at installed gstack/review path

[Lockyer228]

Why

The design-review-army resolver emits the design-checklist path without the gstack/ namespace segment:

• scripts/resolvers/design.ts:47 emits ~/.claude/skills/review/design-checklist.md, but the file is installed at ~/.claude/skills/gstack/review/design-checklist.md.
• The same resolver already uses the correct namespaced form elsewhere in the file (the ~/.claude/skills/gstack/review/... shape), so this is an inconsistency within one resolver.
• /review Step 2 reads .claude/skills/review/checklist.md, a path the installer never creates #2661 fixed the sibling checklist.md path in this section but missed design-checklist.md, so the broken path survives on current main (verified at 394db32, v1.71.0.0: generated ship/sections/review-army.md:91 still carries the broken path, while line 185 of the same generated file shows the correct form).

What changed

• scripts/resolvers/design.ts — one line: point the design-checklist path at ~/.claude/skills/gstack/review/design-checklist.md.
• ship/sections/review-army.md — regenerated (the only shipped artifact that references this resolver output).
• test/gen-skill-docs.test.ts — new regression assertion locking the corrected path.
• test/fixtures/golden/codex-ship-SKILL.md, test/fixtures/golden/factory-ship-SKILL.md — regenerated. After the fix, the codex/factory path rewrites render the checklist as $GSTACK_ROOT/review/design-checklist.md, which is the canonical form already used by the existing golden line (matches the pathRewrites in hosts/codex.ts / hosts/factory.ts).

Live evidence

• On main (394db32): generated ship/sections/review-army.md:91 contains .claude/skills/review/design-checklist.md (broken; missing the gstack/ segment). Line 185 of the same file shows the correct form.
• After the fix + bun run gen:skill-docs: line 91 renders ~/.claude/skills/gstack/review/design-checklist.md, byte-identical to the canonical form used at line 185.
• Mutation check: reverting the source line (reintroducing the broken path) fails the new regression assertion; restoring it goes back to green — the guard actually bites.
• bun run gen-skill-docs --host all regenerates a clean tree: --dry-run reports FRESH, no diff.
• bun test test/gen-skill-docs.test.ts → 416 pass / 0 fail (includes the new assertion and the updated goldens).
• bun test test/host-config.test.ts → 76 pass / 0 fail.
• Same fix shape as /review Step 2 reads .claude/skills/review/checklist.md, a path the installer never creates #2661 (correct the resolver path, regenerate), which landed in v1.68.0.0.

Scope

• No runtime code touched; this is a resolver output fix plus regeneration and test coverage.
• Not addressed here (separate residue noted in /review Step 2 reads .claude/skills/review/checklist.md, a path the installer never creates #2661 discussion): the TODOS-format.md reference in ship/SKILL.md.tmpl — deliberately left out to keep this diff minimal.

Did NOT test

• End-to-end inside a live gstack ship session (the fix is verified at the generator/output/golden level; the skill content itself is unchanged prose).

Fixes #2694

[trunk-io]

Merging to main in this repository is managed by Trunk.

• To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

[Lockyer228]

/trunk merge

[trunk-io]

An error occurred while submitting your PR to the queue: Only users that are a part of this repo's Trunk organization or have write permissions to the repo can submit a PR to the queue