Skip to content

v1.72.1.0 fix(office-hours): add Q<N> open-question prose fallback for Conductor sessions (#2719) - #2729

Open
BharadwajMittapelli wants to merge 1 commit into
garrytan:mainfrom
BharadwajMittapelli:fix/office-hours-conductor-prose-form
Open

v1.72.1.0 fix(office-hours): add Q<N> open-question prose fallback for Conductor sessions (#2719)#2729
BharadwajMittapelli wants to merge 1 commit into
garrytan:mainfrom
BharadwajMittapelli:fix/office-hours-conductor-prose-form

Conversation

@BharadwajMittapelli

Copy link
Copy Markdown

Description

Fixes #2719.

When running inside a Conductor session (CONDUCTOR_SESSION: true), the AskUserQuestion tool is disabled, forcing the runtime to fall back to prose rendering. Previously, the prose fallback instructions in SKILL.md only defined the D<N> Decision Brief format. Because Phase 2A and 2B startup-diagnostic questions are open-ended and have no option sets, the model was unable to fit them into the D<N> format and silently dropped the diagnostic phase.

Changes Implemented

  1. Added Q<N> Prose Form: Added Form 1 (Q<N>) Open-Question Prose Form to generate-ask-user-format.ts alongside the existing Form 2 (D<N>) Decision Brief format.
  2. Updated Frontmatter: Added open_question_tag_prefix: "Q" to office-hours/SKILL.md.tmpl.
  3. Updated Phase Guidance: Added explicit instructions to Phase 2A and Phase 2B sections instructing the runtime to use the Q<N> prose form for open-ended diagnostic questions when AskUserQuestion is unavailable.
  4. Regenerated Skills: Regenerated all skill templates and updated version to 1.72.1.0.
  5. Tests: Added 11 new unit tests in test/resolver-ask-user-format.test.ts and updated mandatory load tests in test/auq-format-always-loaded.test.ts (all passing).

CC: @michaeladair44

@trunk-io

trunk-io Bot commented Aug 29, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@github-actions github-actions Bot changed the title fix(office-hours): add Q<N> open-question prose fallback for Conductor sessions (#2719) v1.72.1.0 fix(office-hours): add Q<N> open-question prose fallback for Conductor sessions (#2719) Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant