Skip to content

fix(ios-qa): allow physical iPad devices in tunnel bootstrap (#2743) - #2779

Open
loulanyue wants to merge 1 commit into
garrytan:mainfrom
loulanyue:fix/2743-allow-ipad-devices-ios-qa-tunnel
Open

fix(ios-qa): allow physical iPad devices in tunnel bootstrap (#2743)#2779
loulanyue wants to merge 1 commit into
garrytan:mainfrom
loulanyue:fix/2743-allow-ipad-devices-ios-qa-tunnel

Conversation

@loulanyue

Copy link
Copy Markdown
Contributor

Summary of Changes

gstack ios-qa rejected connected physical iPad devices during tunnel bootstrap because isIPhoneDevice strictly matched only iPhones. The app debug StateServer is directly reachable over the CoreDevice IPv6 tunnel on iPads.

Fix

  1. Expand device filter: Updated isSupportedIOSDevice in tunnel-bootstrap.ts to accept both iphone and ipad device types/models under iOS / iPadOS platforms.
  2. Clarified error diagnostics: Updated diagnostics to accurately reference iPhone and iPad devices.
  3. Unit tests: Added unit tests in test/tunnel-bootstrap.test.ts verifying physical iPad acceptance and distinct rejection of non-iOS devices. All 26 tests pass.

Fixes #2743

@trunk-io

trunk-io Bot commented Sep 2, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(ios-qa): allow direct QA sessions on physical iPads

1 participant