fix: lower MAX_DEPTH to 4000 to prevent SEGV on CPAN smokers (GH #77)#79
Merged
atoomic merged 1 commit intogaru:masterfrom Feb 24, 2026
Merged
Conversation
) MAX_DEPTH=32000 required ~7.2 MB of C stack before switching to iterative mode — too close to the 8 MB default on Linux and over the limit on some CPAN smoker and container environments. This caused SEGV in t/10-deep_recursion.t on multiple CPAN testers. Lower MAX_DEPTH to 4000 (~900 KB stack), which is safe on any reasonable system. The iterative fallback handles deeper structures correctly. Also lower the test's deep_target from 35000 to 5000: still exceeds MAX_DEPTH/2 (2000 nesting levels) to exercise both recursive and iterative paths, but avoids overflowing Perl's own recursive SvREFCNT_dec during structure cleanup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAX_DEPTH=32000 required ~7.2 MB of C stack before switching to iterative mode — too close to the 8 MB default on Linux and over the limit on some CPAN smoker and container environments. This caused SEGV in t/10-deep_recursion.t on multiple CPAN testers.
Lower MAX_DEPTH to 4000 (~900 KB stack), which is safe on any reasonable system. The iterative fallback handles deeper structures correctly.
Also lower the test's deep_target from 35000 to 5000: still exceeds MAX_DEPTH/2 (2000 nesting levels) to exercise both recursive and iterative paths, but avoids overflowing Perl's own recursive SvREFCNT_dec during structure cleanup.
Fix: #77