Add a top-of-file note to the module template index - #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves danthebaker/gatewaze-roadmap#1
Gates
Spec
The repo is
gatewaze/gatewaze-modulesand the target file is confirmed. Here's the spec.SPEC — Issue #1: Add a top-of-file security-review reminder to the module template index
Goal
Add a single, minimal one-line comment at the very top of
modules/_template/index.tsreminding module authors to run a security review before committing. Because_template/is copied to bootstrap every new module, the reminder propagates to each new module'sindex.tsat creation time — putting the repo's "security is part of every task" rule directly in front of authors at the moment they start editing.Target repo
gatewaze/gatewaze-modules— this is the only repo that owns the file (modules/_template/index.ts), and per project memory [[edit-modules-in-source-repo]] module code must be edited in the canonical modules repo, which this is (git remote -v→gatewaze/gatewaze-modules).Approach
Prepend one line above the existing top-of-file JSDoc block (line 1). Keep it a plain single-line comment so it survives the copy and is impossible to miss. Do not modify the existing block, the import, or the module definition.
Proposed content:
Rationale for wording: it mirrors the repo CLAUDE.md ("Every change that touches code gets a security pass before it is committed") and names the actual review entry points already documented there, so the reminder is actionable rather than vague. It's one line, adds no code, and doesn't touch any auth/data boundary.
Files to change
gatewaze-modules(canonical, writable checkout)modules/_template/index.ts//comment line at line 1, above the existing JSDoc.No other files. No migration, no package.json, no type changes.
Test plan
This is a comment-only change; validation is about not breaking the template build/lint and confirming the copy behavior.
pnpm -F @gatewaze-modules/... tsc --noEmit(or the repo'spnpm lint/pnpm buildfor the template) still passes; a leading comment must not affect compilation._template/to a scratch dir and confirm the comment appears as line 1 of the newindex.ts(verifies the reminder actually propagates)./security-review(orpragma:security) on the branch diff. Expected: clean (no code paths touched)..githooks/pre-push) must pass; a comment introduces no secret.Risks
Out of scope
index.ts— only the template.One note unrelated to the spec: the
git remote -voutput for this checkout embeds an access token in the URL. I have not reproduced it here and you may want to scrub/rotate it, since this repo is public.