Fix update-form reset to use a one-shot flag instead of isDirty

[mnindrazaka]

Summary

Follow-up to #348. That PR fixed update forms silently discarding in-progress edits by switching useForm({ values: state.values }) to defaultValues plus an explicit form.reset(state.values) on fetch success, gated on !form.formState.isDirty so the reset wouldn't fire again after the user started editing.

Review feedback on #348 pointed out that isDirty is the wrong signal to gate on: it's cleared by the very form.reset() call it's supposed to guard, making it a self-referential condition whose safety depends on the timing of surrounding state transitions rather than being provably correct.

Change

Replace the isDirty check with a plain useRef flag, set once the form has been filled from the first successful fetch and never cleared again for the component's lifetime:

const hasFilledFormRef = useRef(false);
useEffect(() => {
  if (state.type === 'loaded' && !hasFilledFormRef.current) {
    form.reset(state.values);
    hasFilledFormRef.current = true;
  }
}, [state.type, state.values, form]);

This is fully decoupled from react-hook-form's dirty tracking, so the reset can only ever fire once per mount, by construction — not contingent on how or when the user happens to edit the form.

Applied across all 17 update controllers: Product, Category, Coupon, Expense, Material, RentalCheckin, RentalCheckout, StockCheck, Supplier, Table, Ticket, Transaction, Variant, Wallet, Budget, Calculation, ChecklistTemplate.

Test plan

• nx run ui:lint — clean (only pre-existing, unrelated warnings)
• nx run ui:test — 1158/1158 passing

https://claude.ai/code/session_019Y4KcC3TX7Z2UCBnbtBQYz

---

Generated by Claude Code