fix: ensure pathPrefix works with trailingSlash option #39164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the `pathPrefix` option was ignored when the trailing slash option was set to "never." The cause was that adding the prefix seemed to be left out of a few code paths.
gatsbot
bot
added
the
status: triage needed
JoelBonetR
reviewed
Jan 22, 2025
|
|
||
| function absolutify(path, current) { | ||
| const prefixed = withPrefix(path) | ||
| // If it's already absolute, return as-is |
There was a problem hiding this comment.
The comment is no longer true so I'm wondering if line 24 should be return path instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes an issue where the
pathPrefixoption was ignored when the trailing slash option was set to "never." The cause was that adding the prefix seemed to be left out of a few code paths.Documentation
This feature is documented on this page, however, it doesn't work as described right now when the
trailingSlashoption is set tonever.Tests
I've tested this change on a production Gatsby site, but haven't added any automated tests. I'm happy to attempt to do so, but I couldn't get tests working locally, nor could I push to my fork (maybe because of the repository size).
Related Issues
Fixes #39043