12 ➡️ 13 (main) #805
Merged
12 ➡️ 13 (main) #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [sdf6] Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * more fixes, new version of script Signed-off-by: Louise Poubel <louise@openrobotics.org>
* [sdf4] Update BitBucket links Signed-off-by: Louise Poubel <louise@openrobotics.org> * fix a few more links Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: chapulina <louise@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Patch popen/pclose method for Windows
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Backport sdf6: Move recursiveSameTypeUniqueNames from ign.cc to parser.cc
* Prepare version 6.3.0 * Add entry in Changelog for 497
* Fix flattening logic for composed names in nested models When nested models use names composed by several elements (i.e: my_model::link) these were not converted by the flattening logic inside parser.cc. The change makes the logic to work with composed names. Added a test to check that this is indeed working as expected. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
) Translate poses of nested models inside other nested models When addNestedModel function is called, it processes links and joints to translate the pose accordingly to parent pose. This was not done for nested models inside the SDF being processed. The change includes nested models in the same way that is doing for links and add a test that fails without the change. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Prepare version 6.3.1 * Implement github actions for sdf6 branch Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* parse rpyOffset as radians Signed-off-by: Ian Chen <ichen@osrfoundation.org> * update tf for xyz and rpy offsets Signed-off-by: Ian Chen <ichen@osrfoundation.org> * remove inverse transform function in urdf parser Signed-off-by: Ian Chen <ichen@osrfoundation.org> * inject corrected_offets tag Signed-off-by: Ian Chen <ichen@osrfoundation.org> * Fix tag removal logic Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Pass by const reference * Remove unused variable * Simplify redundant logic Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* ign_TEST: expect joint_axis_infinite_limits valid * Add missing link6 to test/sdf/joint_axis_*.sdf Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* ign_TEST: expect joint_axis_infinite_limits valid * Add missing link6 to test/sdf/joint_axis_*.sdf Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Adds sdf::testing::SourceFile, sdf::testing::TestFile, sdf::testing::env, and sdf::testing::setenv and updates tests to use them. This makes it easier to backport other changes from newer branches. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Merge 10 -> 11 and resolve conflicts
Signed-off-by: Nick Lamprianidis <nlamprian@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Add Joint DOM API to access joint sensors Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Add missing file Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * modified Joint::SensorNameExists Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
* Added Force Torque Noise functions + Unit tests Signed-off-by: Devansh <devansh@vt.edu> Co-authored-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* Support accessing mutable sensor types Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added simple test Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added more tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added asserts Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Prepare for v9.7.0 Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
* Prepare for 12.2.0 Signed-off-by: Nate Koenig <nate@openrobotics.org> * Updated changelog Signed-off-by: Nate Koenig <nate@openrobotics.org> * fix changelog Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
The correct default value is now computed based on the attributes of the pose, so `<pose rotation_format='quat_xyzw'/>` will have the the value '0 0 0 0 0 0 1' instead of the default string specified in pose.sdf. Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Added Add & Clear function to World, Model, and Link Signed-off-by: Nate Koenig <nate@openrobotics.org> * spelling Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Added ToElement conversion for physics and atmosphere Signed-off-by: Nate Koenig <nate@openrobotics.org> * spelling Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Aded ToElement conversion for shapes Signed-off-by: Nate Koenig <nate@openrobotics.org> * doxygen Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
* Working on material DOM ToElement Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update material ToElement Signed-off-by: Nate Koenig <nate@openrobotics.org> * Use floats Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix build Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
* Added ToElement conversion for Collision, Surface, and Visual Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update src/Visual_TEST.cc Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Marco A. Gutiérrez <marco@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Added ToElement for ParticleEmitter and Link Signed-off-by: Nate Koenig <nate@openrobotics.org> * expect double eq Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
* Adding toelement for model and actor Signed-off-by: Nate Koenig <nate@openrobotics.org> * Updated tests Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Added more ToElement functions Signed-off-by: Nate Koenig <nate@openrobotics.org> * Revert Link toelement changes Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added toelement conversion for world, scene, sky, gui Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix element insertion, and updated tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update docs Signed-off-by: Nate Koenig <nate@openrobotics.org> * Updates Signed-off-by: Nate Koenig <nate@openrobotics.org> * minor doxygen update Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Support URI in the Model DOM Signed-off-by: Nate Koenig <nate@openrobotics.org> * One minor test Signed-off-by: Nate Koenig <nate@openrobotics.org> * placement frame and static Signed-off-by: Nate Koenig <nate@openrobotics.org> * relative_to Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added nested include test Signed-off-by: Nate Koenig <nate@openrobotics.org> * Updates Signed-off-by: Nate Koenig <nate@openrobotics.org> * useincludetag Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Added plugin to SDF DOM Signed-off-by: Nate Koenig <nate@openrobotics.org> * tweaks Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fixed doxygen Signed-off-by: Nate Koenig <nate@openrobotics.org> * Updates Signed-off-by: Nate Koenig <nate@openrobotics.org> * Update plugin copy and tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Remove string and add move functions Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix build and tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix windows warnings Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
The buildFrameAttachedToGraph and buildPoseRelativeToGraph have overloads for the type of parent element, but the code in each overload is very similar to each other. This refactors these functions so there's less code duplication. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
…used angles (#689) * Ruby option to print in_degrees or snap_to_degrees Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic PrintConfig added Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * PrintConfig gets passed into printing implementations of Element and Param Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Adding basic test for print options Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Reverting to PrintConfig with basic API Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved creation of PrintConfig into ign functions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Param value GetPoseAsString and tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved attribute painting to its own function, fixed test strings Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added basic tests for pose rotation input as quaternions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using different flags for ign sdf -p, allow snapping to different values Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Disabling test on windows, fixing comment Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Remove stale function, fixed linting Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Adding tolerance as a argument, added tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Use 3 spaces when changing rotation formats or snapping to degrees Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added check for tolerance larger than snapping interval Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moving PrintAttributes to ElementPrivate to remain ABI stability Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using true/false instead of 1/0 Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Remove use of SDF_ASSERT in GetAsString Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added tests for //include/pose Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Adding parsing passing test for empty quat_xyzw pose Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added check for default string values to be modified when rotation_format is defined Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Reparsing translates default value into string to be used if values have not been assigned to param Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using StringFromValueImpl for getting strings from all ParamVariants Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactor pose string from value into its own function Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fixing casting erroerror, added documentation and tests for tolerance < interval Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Correcting stale comments Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fixing snapToInterval math, added more tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Removed unneeded visibility macro Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Adding return documentation and using const reference to variant instead of pointer Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Returning string directly, removing stale _config, reverting strValue to nullopt Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Remove use of assertions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Suggested changes to #729 (#748) Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Using three space delimiter between position and rotation if attributes are set Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added comment regarding use of default PrintConfig in Reparse Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Adding equality comparison for PrintConfig Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Removed stale include Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Uniied string and value parsing behavior, and modified necessary tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Overloaded function to maintain ABI stability Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fixing missing space in test for exec command Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Adding comment regarding attributeExceptions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Indenting help message, adding test for shuffling command flags Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Modifying cmd flag shuffling test to handling flags with arguments too Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Removed Get from PrintConfig getter functions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using std optional's converting constructor Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Modified snapToInterval implementation, added test Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added bool type specific value parser, values are parsed using ParamStreamer by default Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Reverting all unnecessary changes made in sdf12 to old tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added comparison for PreserveIncludes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Check for 'type' attribute in unknown elements as well, in order to parse booleans into true/false, instead of 1/0 Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Only checking for pose related PrintConfig options for returning string instead of default PrintConfig Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added comment regarding sanitizing -0 in test outputs Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This was referenced Dec 27, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #805 +/- ##
==========================================
+ Coverage 88.22% 90.70% +2.48%
==========================================
Files 76 78 +2
Lines 11437 12439 +1002
==========================================
+ Hits 10090 11283 +1193
+ Misses 1347 1156 -191
Continue to review full report at Codecov.
|
scpeters
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
sdf12tomainNote to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸