fix(config): ignore ambient HOSTNAME that echoes the machine hostname - #184
Merged
Conversation
Containers and some CI runner images auto-export HOSTNAME as the machine name, which made the server silently bind away from localhost. Treat a HOSTNAME equal to os.hostname() as ambient - warn and keep 127.0.0.1 - while deliberate values like 0.0.0.0 or localhost keep working unchanged.
Owner
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183
Containers and some CI runner images auto-export
HOSTNAME=<machine hostname>, andconfig.tsreadsHOSTNAMEas the bind address — so in those environments the server silently binds to the machine hostname instead of localhost (full details and repro in #183).Minimal guard: a
HOSTNAMEequal toos.hostname()is treated as ambient — a warning is logged (pointing atHOSTNAME=0.0.0.0for anyone who does want non-localhost binding) and the default127.0.0.1is kept. Deliberate values keep working unchanged:0.0.0.0,127.0.0.1, any interface IP, andlocalhostare passed through as before (covered by tests).Deliberately not included (see the issue): a dedicated variable name and/or restricting the value to IP literals — both are policy calls; happy to follow up either way.