Part II, Lesson 5#40
Closed
evie-calico wants to merge 0 commit intogbdev:masterfrom
evie-calico:lesson4
Closed
Conversation
Contributor
Author
|
I'll leave this as a draft until #37 is merged |
ISSOtm
suggested changes
Jan 14, 2023
Member
ISSOtm
left a comment
ISSOtm
left a comment
There was a problem hiding this comment.
Nice! Something short and simple, for once 😅
Contributor
Author
|
Yeah, much less than I expected. Hopefully the review process won't take as long because of that :) |
avivace
requested changes
Feb 8, 2023
Member
|
I will say it once again: this PR needs to be rebased in order to be properly reviewed. It adds a separate file so it can even be rebased against master and we proceed from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16