Part II, Lesson 6#47
Merged
avivace merged 25 commits intogbdev:masterfrom Apr 18, 2023
evie-calico:master
Merged
Conversation
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Antonio Vivace <avivace4@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
avivace
approved these changes
Mar 1, 2023
Member
avivace
left a comment
avivace
left a comment
There was a problem hiding this comment.
Wow, this one looks very nice and simple! I think it's also in a pretty good state already and could be merged. I would just add the SVG from Pan Docs audio.
Contributor
Author
|
done :) I'd hold off on merging this though, as the brick-breaking sfx relies on the previous chapter. |
avivace
reviewed
Mar 8, 2023
| You can almost think of this as a custom instrument, though it's very limited. | ||
|
|
||
| Here's a diagram from [this page](https://gbdev.io/pandocs/Audio.html) of the Pandocs showing each channel. | ||
| <svg viewBox="0 0 480 220" preserveAspectRatio="xMidYMid meet" xmlns="http://www.w3.org/2000/svg"> |
Member
There was a problem hiding this comment.
Just a note for @ISSOtm : this is a bit of a problem created by the fact that we are inline-injecting SVGs in the Pan Docs..
avivace
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
This could go into a lot more depth about what the channel 2 and 4 registers do. Feedback would be nice :)