Skip to content

Make tests work with CTest#1539

Merged
Rangi42 merged 1 commit intogbdev:masterfrom
JL2210:cmake-tests
Oct 15, 2024
Merged

Make tests work with CTest#1539
Rangi42 merged 1 commit intogbdev:masterfrom
JL2210:cmake-tests

Conversation

@JL2210
Copy link
Copy Markdown
Contributor

@JL2210 JL2210 commented Oct 9, 2024

tests expect rgb{asm,link,fix,gfx} to be in ./

add CTestCustom.cmake to pull in dependencies

add option to disable non-free tests

Switch find_package conditions to explicitly state that it's broken on MacOS, and use pkg-config there only.

@Rangi42 Rangi42 marked this pull request as draft October 9, 2024 19:31
@Rangi42 Rangi42 added tests This affects the test suite meta This isn't related to the tools directly: repo organization, maintainership... builds This affects the build process or release artifacts labels Oct 9, 2024
@JL2210 JL2210 marked this pull request as ready for review October 14, 2024 01:50
@JL2210 JL2210 force-pushed the cmake-tests branch 3 times, most recently from af5c1ce to 34e4130 Compare October 14, 2024 18:28
@JL2210 JL2210 marked this pull request as draft October 14, 2024 18:38
tests expect rgb{asm,link,fix,gfx} to be in ./

add CTestCustom.cmake to pull in dependencies

add option to disable non-free tests

fix github actions
@JL2210 JL2210 marked this pull request as ready for review October 14, 2024 19:28
Copy link
Copy Markdown
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about fine to me. Since in the end we are still using pkg-config for libpng, I think #1543 can also be closed?

@JL2210
Copy link
Copy Markdown
Contributor Author

JL2210 commented Oct 15, 2024

Looks about fine to me. Since in the end we are still using pkg-config for libpng, I think #1543 can also be closed?

Yeah. FindPNG is pretty unstable, evidently.

@Rangi42 Rangi42 added this to the v0.9.0 milestone Oct 15, 2024
@Rangi42 Rangi42 merged commit e623aeb into gbdev:master Oct 15, 2024
@JL2210 JL2210 deleted the cmake-tests branch October 15, 2024 23:28
@Rangi42
Copy link
Copy Markdown
Contributor

Rangi42 commented Jan 28, 2025

Note that these are run by doing cmake --build build --target test (after the usual cmake --build build -j4 --verbose and cmake --install build --verbose).

@ISSOtm ISSOtm mentioned this pull request Apr 10, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds This affects the build process or release artifacts meta This isn't related to the tools directly: repo organization, maintainership... tests This affects the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants