Refactor lexing of fixed-point numbers#1915
Merged
Merged
Conversation
Rangi42
added
rgbasm
Contributor
Author
|
There's a pre-existing bug here: |
Rangi42
commented
Apr 4, 2026
ISSOtm
requested changes
Apr 4, 2026
Member
ISSOtm
left a comment
ISSOtm
left a comment
There was a problem hiding this comment.
I guess breaking apart a state machine into straight-line code is a readability win. Nice job!
ISSOtm
requested changes
Apr 5, 2026
…edPoint` This incidentally fixes a bug with too-long fixed-point literals that have precision suffixes.
ISSOtm
requested changes
Apr 6, 2026
Member
ISSOtm
left a comment
ISSOtm
left a comment
There was a problem hiding this comment.
I have some more refactoring ideas. Let me know if you think this is getting too bikeshed-y.
ISSOtm
approved these changes
Apr 7, 2026
Member
ISSOtm
left a comment
ISSOtm
left a comment
There was a problem hiding this comment.
Thanks for pulling through this! It was more painful than anticipated, huh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readFractionalPartwas a messy state machine with unclear correspondence to the actual fixed-point literals we accept and reject, so I refactored it.This also distinguishes between "no digits after
q" and "only0s afterq", so we no longer need to error about "significant digits".I also renamed
nonDigittoprevSeparatorin other number-parsing functions, not just the fixed-point ones.