Attempt to optimize charmaps#1954
Merged
Rangi42 merged 3 commits intogbdev:masterfrom Apr 17, 2026
Merged
Conversation
Contributor
Author
|
Tested this on
Not sure if this is significant, but it's at least not harming performance so far. Also, to measure maximum RAM usage,
|
This should save memory at the cost of O(n) instead of O(1) access, which should be okay because the `next` vector is generally small.
f67044e to
96e847b
Compare
ISSOtm
reviewed
Apr 18, 2026
Member
ISSOtm
left a comment
There was a problem hiding this comment.
This PR looks no worse than the previous implementation, but I'm thinking that this entire module is starved for comments, heh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in discussion regarding https://burntsushi.net/transducers/.
There are a lot of possible ways we could optimize our charmap data structure and algorithms. So far this PR only implements one, and hasn't tried measuring whether it's even a reliable improvement yet.