Skip to content

Feature/registration redirect - #181

Merged
gbowne1 merged 7 commits into
gbowne1:masterfrom
vktr-r2:feature/registration-redirect
Sep 21, 2023
Merged

Feature/registration redirect#181
gbowne1 merged 7 commits into
gbowne1:masterfrom
vktr-r2:feature/registration-redirect

Conversation

@vktr-r2

@vktr-r2 vktr-r2 commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Resolves Issue 172:

Files Changed:

  • userController.js
  • Register.jsx

In userController.js:

  1. Updated signup function to generate new token during registration process
  2. Updated signup function to send registration confirmation email upon successful registration

In Register.jsx:

  1. Import useNavigate from react-router-dom to handle navigation
  2. Update handleRegister function to save token and user in local storage
  3. Redirect to home route after 200 response received
Screen.Recording.2023-09-20.at.20.46.03.mov
Screenshot 2023-09-20 at 20 52 59

@vktr-r2
vktr-r2 requested a review from gbowne1 as a code owner September 21, 2023 01:06
@gbowne1 gbowne1 added the enhancement New feature or request label Sep 21, 2023
@gbowne1 gbowne1 added this to the Frontend milestone Sep 21, 2023

@gbowne1 gbowne1 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked out this change locally for testing and review for merging
  • Manually reviewed for syntax and grammar errors
  • Reviewed the PR description and related issue for context.

Tested this change and it appears this adds a feature to redirect during the registration progress.

It also does not appear to cause any additional warnings outside of ones that already exist in the browser console or in ESLint.

Approving for merge. Thank you for the opportunity to review your PR @vktr-r2 !

@gbowne1

gbowne1 commented Sep 21, 2023

Copy link
Copy Markdown
Owner

1 more PR cycle and I will invite you to be a collaborator! Thanks for your contribution!

@LOGESH-B LOGESH-B left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @vktr-r2
Thanks for youur contribution🙌
Approving for merge

@BlackBond06 BlackBond06 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes made in PR locally for errors. Changes works as described in PR, updating the Registration/SignUp feature. Approving for merge.

@gbowne1
gbowne1 merged commit 3a6173a into gbowne1:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Feature request] Minor: Redirect user into app upon successful registration

4 participants