Feature/registration redirect - #181
Merged
Merged
Conversation
gbowne1
approved these changes
Sep 21, 2023
gbowne1
left a comment
Owner
There was a problem hiding this comment.
- Checked out this change locally for testing and review for merging
- Manually reviewed for syntax and grammar errors
- Reviewed the PR description and related issue for context.
Tested this change and it appears this adds a feature to redirect during the registration progress.
It also does not appear to cause any additional warnings outside of ones that already exist in the browser console or in ESLint.
Approving for merge. Thank you for the opportunity to review your PR @vktr-r2 !
Owner
|
1 more PR cycle and I will invite you to be a collaborator! Thanks for your contribution! |
BlackBond06
approved these changes
Sep 21, 2023
BlackBond06
left a comment
Collaborator
There was a problem hiding this comment.
Tested changes made in PR locally for errors. Changes works as described in PR, updating the Registration/SignUp feature. Approving for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Issue 172:
Files Changed:
In userController.js:
In Register.jsx:
Screen.Recording.2023-09-20.at.20.46.03.mov