Add derivate_types classification and menu action to set the derivate type#310
Merged
Conversation
… type
* add local derivate_types classification with the categories content and
edition_tei, including de, en and tr labels, and load it during setup
* add CMODerivateResource exposing rsc/cmo/derivate/{id}/set-type/{type} to
set the derivate_types category of a derivate (write permission required)
* add a file-area-type selector to the derivate actions menu; the labels are
read from the classification and the current type is marked with a check icon
sebhofmann
force-pushed
the
derivate-types-classification
branch
from
July 15, 2026 17:04
bb4098c to
b32fe77
Compare
kkrebs
requested changes
Jul 16, 2026
kkrebs
left a comment
kkrebs
left a comment
Collaborator
There was a problem hiding this comment.
looks good for me. I found only a minor text issue
kkrebs
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
derivate_typesclassification to the project and lets editors set a derivate's type directly from the derivate actions menu.Changes
derivate_typesclassification with two categories,content(Inhalt) andedition_tei(Editions TEI). Loaded during setup viaupdate classification from file.CMODerivateResourceatrsc/cmo/derivate/{id}/set-type/{type}. Validates the id, checks write permission, validates the category against the classification, replaces any existingderivate_typesentry and redirects back.Notes
derivate_typesclassification only containscontentandedition_teion purpose, not the full upstream list.messages_de.propertiesstays ISO-8859-1; only ASCII keys were appended.Test
mvn -pl cmo-module -am clean installbuilds green.