Fix possible overflow in unavailability estimator #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
dfquaresma
approved these changes
Dec 23, 2017
Member
There was a problem hiding this comment.
Great improvement! We are almost there!
Consider what I have said and done at #5 for this PR too. Now I believe that we have only two last dangerous counters: incoming and finished. Both at interceptor.go.
I don't have any more comments for this PR. It seems excelent to me. Thanks!
Contributor
Author
|
Excellent reminder about fixing the counters at interceptor.go (completely forgot it). Fixed the PR text. Going to send a next PR with the interceptor.go changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding unit tests. WIP #1