feat(audit): a report nobody finishes reading teaches nothing - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2a. Every finding printed its full lesson - evidence, why, fix, verify - so a network with fifteen findings produced a wall of text people stop reading. A lesson nobody reads teaches nothing, which defeats the point of having a teaching layer at all.
Depth is now something you ask for. Measured on five findings: 75 lines before, 13 after.
-vis exactly the previous output, unchanged.--jsonand--explainare untouched.Two choices worth naming:
CRITICALheading above a group. It costs nine columns and buys a line that still says what it is once it has been copied into a ticket or a message. The group headings are still there under-v, where there is room.-v; without it the teaching layer exists and nobody ever finds it.print_headlinereusesprint_fieldwith the severity as its label, so wrapping and the hanging indent came for free.New
tests/test_cli_output.pydrivescmd_auditagainst a stubbeddiscover, so it pins the rendering without touching a network. The one that matters most istest_both_views_report_the_same_findings- brevity is allowed to drop detail, it is not allowed to drop a finding.