Fix broken documentation URLs - #741
Merged
Merged
Conversation
- meep: GDSII_Import → GDS_Import (page renamed upstream) - palace: config/solver/ → config/reference/ (docs restructured) - jupyterbook.org: add /en/stable/ prefix (docs moved) - gdsfactory docs: update to current paths Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jackgdsf
requested review from
ThomasPluck,
joamatab and
nikosavola
as code owners
July 25, 2026 15:12
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- For the Palace documentation links, consider updating to more specific anchors within
config/reference(e.g., pointing directly to theSolver/Linear/Drivensections) to preserve the original level of guidance for users. - Double-check whether using the
/en/stable/prefix for all Jupyter Book references is desired long-term, as hardcoding the versioned path may require future updates when the default stable version changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For the Palace documentation links, consider updating to more specific anchors within `config/reference` (e.g., pointing directly to the `Solver`/`Linear`/`Driven` sections) to preserve the original level of guidance for users.
- Double-check whether using the `/en/stable/` prefix for all Jupyter Book references is desired long-term, as hardcoding the versioned path may require future updates when the default stable version changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…d _toc.yml These files were removed upstream as part of the docs migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #740
GDSII_Import→GDS_Import(page renamed upstream)config/solver/→config/reference/(docs restructured)/en/stable/prefix (docs moved)Test plan
Reminder: AI-created PRs still require human review of the actual code changes before merge. I'll open the PR, but a human must review and approve it.
🤖 Generated with Claude Code
Summary by Sourcery
Update documentation references to point to current external URLs without changing runtime behavior.
Documentation: