fix: remove duplicated summary pages from docs nav - #747
Merged
joamatab merged 1 commit intoAug 1, 2026
Conversation
Remove thin/empty landing pages (plugins_optimization.md,
plugins_process.md, plugins_mode_solver.md, plugins_fdtd.md,
plugins_circuits.md) that duplicate the nav section headings.
Also remove plugins_mesh.md and sdl.md which aren't in the nav
and contain broken Jupyter Book {tableofcontents} syntax.
Fixes gdsfactory#746
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jackgdsf
requested review from
ThomasPluck,
joamatab and
nikosavola
as code owners
August 1, 2026 01:58
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves duplicated and unused documentation landing pages from the docs navigation and deletes their corresponding markdown files to clean up the Jupyter Book migration leftovers. Flow diagram for cleaned docs navigation structureflowchart TD
docs[Docs root]
design[Design section]
optimization[Optimization]
devicesim[Device_Simulators]
modesolvers[Mode_Solvers]
fdtd[FDTD]
circuits[Circuit_Simulators]
docs --> design
design --> optimization
design --> devicesim
design --> modesolvers
design --> fdtd
design --> circuits
optimization --> ray_optimiser[notebooks/ray_optimiser.md]
optimization --> pso[notebooks/pso.md]
devicesim --> femwell_heater[notebooks/femwell_02_heater.md]
devicesim --> tcad_analytical[notebooks/tcad_02_analytical_process.md]
devicesim --> tcad_implant[notebooks/tcad_03_numerical_implantation.md]
modesolvers --> femwell_modes[notebooks/femwell_01_modes.md]
modesolvers --> fdfd[notebooks/mode_solver_fdfd.md]
modesolvers --> mpb_waveguide[notebooks/mpb_001_mpb_waveguide.md]
fdtd --> tidy3d[notebooks/tidy3d_00_tidy3d.md]
fdtd --> lumerical_fdtd[notebooks/lumerical_1_fdtd_sparameters.md]
circuits --> sax[notebooks/sax_01_sax.md]
circuits --> vlsir[notebooks/vlsir_netlist.md]
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
joamatab
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins_optimization.md,plugins_process.md,plugins_mode_solver.md,plugins_fdtd.md,plugins_circuits.md) that duplicate the nav section headings — leftovers from the Jupyter Book migration.plugins_mesh.mdandsdl.mdwhich aren't in the nav and contain broken Jupyter Book{tableofcontents}syntax.Fixes #746
Test plan
Reminder: AI-created PRs still require human review of the actual code changes before merge. I'll open the PR, but a human must review and approve it.
🤖 Generated with Claude Code
Summary by Sourcery
Streamline the documentation by removing obsolete plugin landing pages from the navigation and deleting unused or broken docs files left over from the Jupyter Book migration.
Bug Fixes:
Enhancements:
Build: