refactor(gstd): split prog::create_program into two functions#3050
Merged
Conversation
StackOverflowExcept1on
force-pushed
the
av/create-program
branch
from
2765f63 to
d77a670
Compare
ukint-vs
approved these changes
Aug 10, 2023
shamilsan
approved these changes
Aug 12, 2023
shamilsan
left a comment
shamilsan
left a comment
Contributor
There was a problem hiding this comment.
Now it looks more consistent, great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3026
Now we have two versions of
create_program:create_program_bytes(code_id, payload: impl AsRef<[u8]>, value)create_program<E: Encode>(code_id, payload: E, value)Why?
create_program<E: Encode>on the stack