refactor(core): Clear ContextStore state created by *_commit syscalls#4288
Closed
refactor(core): Clear ContextStore state created by *_commit syscalls#4288
Conversation
playX18
added
the
A1-inprogress
breathx
requested changes
Oct 14, 2024
Member
breathx
left a comment
breathx
left a comment
There was a problem hiding this comment.
Your goal is to fix all the modifying code, not only clear it. We dont need to store/write any related data at all. Moreover, context shouldn't even contain the field
Member
Author
|
Implemented everything that is needed to remove commit state from ContextStore but there's still some tests that are failing and I am unable to figure it out yet. |
Member
Author
|
Closing this in favor of opening another PR with much cleaner code and solution to this problem (which does not introduce errors in a fuzzer) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit before implementing actual migrations to clear all data creates by
_commitsyscalls family.