Skip to content

refactor(core): commit family of syscalls does not keep state between executions#4304

Merged
playX18 merged 20 commits intomasterfrom
ap/tmp-store
Nov 13, 2024
Merged

refactor(core): commit family of syscalls does not keep state between executions#4304
playX18 merged 20 commits intomasterfrom
ap/tmp-store

Conversation

@playX18
Copy link
Copy Markdown
Member

@playX18 playX18 commented Oct 22, 2024

New PR based on #4288 but with cleaner code and solution that does not break a fuzzer. Still WIP but all that is left is write a migration and fix tests.

@breathx

@playX18 playX18 marked this pull request as ready for review October 22, 2024 02:55
@playX18 playX18 requested a review from breathx October 22, 2024 03:29
@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label Oct 22, 2024
Copy link
Copy Markdown
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to fix CI

Comment thread pallets/gear/src/tests.rs Outdated
Comment thread core/src/message/context.rs Outdated
Comment thread core/src/message/context.rs Outdated
Comment thread core/src/message/context.rs Outdated
Comment thread core/src/message/context.rs Outdated
@breathx
Copy link
Copy Markdown
Member

breathx commented Nov 5, 2024

Otherwise, lgtm

@breathx breathx added A3-gotissues PR occurred to have issues after the review and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 5, 2024
@playX18 playX18 self-assigned this Nov 12, 2024
@playX18 playX18 added the A0-pleasereview PR is ready to be reviewed by the team label Nov 12, 2024
@playX18 playX18 requested a review from breathx November 12, 2024 07:19
Comment thread core/src/message/context.rs Outdated
Comment thread core/src/message/context.rs Outdated
Comment thread pallets/gear-messenger/src/migrations/context_store.rs
Comment thread pallets/gear-messenger/src/migrations/context_store.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0-pleasereview PR is ready to be reviewed by the team A3-gotissues PR occurred to have issues after the review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants