feat(core-processor): expand panic reporting for Sails

[m62624]

Expanded the RPC panic limit by preserving raw bytes for Sails error decoding.
Required for gear-tech/sails#1194

@reviewer-or-team

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
core-processor/src/processing.rs	47% smaller
pallets/gear/src/runtime_api.rs	22% smaller
core-processor/src/common.rs	0% smaller
pallets/gear/src/tests.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @m62624, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the system's error reporting capabilities, particularly for program panics. By introducing a dedicated structure to distinguish between raw panic bytes and generic error messages, and by ensuring these raw bytes are preserved and exposed as full hexadecimal strings via RPC, the change provides more comprehensive and actionable diagnostic information. This enhancement is specifically designed to support better error decoding and analysis in dependent systems like Sails.

Highlights

• Enhanced Panic Reporting Structure: Introduced a new DispatchErrorReason enum in core-processor/src/common.rs to differentiate between raw panic bytes (PanicBuffer) and general string error messages. This provides a more structured way to handle and report different types of dispatch errors.
• Preservation of Raw Panic Data: Modified the DispatchOutcome enum to utilize the new DispatchErrorReason, ensuring that raw panic bytes are captured and preserved during error processing in core-processor/src/processing.rs instead of being converted to potentially truncated strings.
• Full Hex Panic Payload in RPC: Updated the runtime API in pallets/gear/src/runtime_api.rs to format DispatchErrorReason::Panic variants as full hexadecimal strings using HexDisplay. This change is crucial for external tools like Sails, which require untruncated raw panic data for accurate error decoding.
• Validation Test Case: Added a new test userspace_panic_rpc_returns_full_hex in pallets/gear/src/tests.rs to explicitly verify that the RPC returns the complete hex payload of a userspace panic, confirming the intended behavior of preserving and displaying full panic information.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request expands panic reporting by preserving raw bytes for error decoding, which is a great improvement for debugging. The introduction of DispatchErrorReason enum to differentiate between panic bytes and string messages is a clean solution. The changes in core-processor correctly propagate this new error type. The RPC layer in pallets/gear is updated to format the raw panic bytes as a hex string, which is what clients like Sails would need. A new test case is added to verify this behavior.

I've found one issue in the formatting of the hex string in the RPC error message, which would cause an incorrect output. My review includes a suggestion to fix it.

[breathx]

tbd