Fix subtype/subclass miss branch issue#398
Merged
Merged
Conversation
Use `isinstance(*)` rather than `type(*)==` to avoid the miss of branch when subclass of `ea.Population` is used.
|
Thank you. Your email is received and will be handled as soon as possible
|
|
您好，您的邮件冯颖已收到！
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a type checking issue in the optimize function that would cause subclasses of ea.Population to be incorrectly rejected. The fix changes from exact type comparison (type(*) == ea.Population) to proper inheritance checking (isinstance(*, ea.Population)).
Changes:
- Changed line 96 from
type(prophet) == ea.Populationtoisinstance(prophet, ea.Population)to properly handle subclasses
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
isinstance(*)rather thantype(*)==to avoid the miss of branch when subclass ofea.Populationis used.