Skip to content

fix: slugify lawn_mower entity_id, fixes #366#367

Merged
geertmeersman merged 1 commit into
mainfrom
dev-current
Mar 17, 2026
Merged

fix: slugify lawn_mower entity_id, fixes #366#367
geertmeersman merged 1 commit into
mainfrom
dev-current

Conversation

@geertmeersman

@geertmeersman geertmeersman commented Mar 17, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Changes
    • Updated the lawn mower entity identifier format in Home Assistant from the previous naming convention to a new slug-based format. Users referencing the lawn mower entity in automations or configurations may need to update those references accordingly.

@github-actions github-actions Bot added fix A bug fix patch A change requiring a patch version bump labels Mar 17, 2026
@coderabbitai

coderabbitai Bot commented Mar 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6444540c-6880-45f7-8300-a41f3ca8beda

📥 Commits

Reviewing files that changed from the base of the PR and between f881ebb and 377da45.

📒 Files selected for processing (1)
  • custom_components/robonect/lawn_mower.py

📝 Walkthrough

Walkthrough

The RobonectLawnMowerEntity initialization was modified to set the entity_id using the slug attribute instead of base_topic. This changes the Home Assistant entity identifier format from lawn_mower.{base_topic}_robonect to lawn_mower.{slug}.

Changes

Cohort / File(s) Summary
Entity ID Initialization
custom_components/robonect/lawn_mower.py
Modified RobonectLawnMowerEntity.__init__ to use slug instead of base_topic for entity_id generation, altering the entity identifier naming scheme.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A slug slides softly through the lawn,
No more base_topics to rely upon,
Fresh entity_ids now take their place,
Our mower's renamed with elegant grace!
Hippity-hop, the change is done. 🍀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: using a slugified value for the lawn_mower entity_id instead of base_topic, and references the related issue.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-current
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

@geertmeersman geertmeersman merged commit 240b64d into main Mar 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A bug fix patch A change requiring a patch version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant