docs(bench): drop redundant GEIST_WEIGHT_MMAP=1; fix stale spec-head default - #62
Merged
Merged
Conversation
…ale spec-head default GEIST_WEIGHT_MMAP=1 is already the runtime default (arch_state.c), so setting it on the bench command lines was cargo-cult. Also correct TERNARY_BITNET.md: the i8-sketch spec head is now default-on for greedy decode on an eligible tied lm_head (spec_head.c), not opt-in.
geisten
added a commit
that referenced
this pull request
Jul 5, 2026
…72) The metal-beat-llamacpp-plan.md close (987/81.2, 2026-07-04) predates the #58/#60 Metal work and the #62/#63 dead-flag cleanup. Add a dated data point: a fresh cool compare_metal.sh on main (1020d45) reads 1006 pp512 / 81.6 tg64 / 445 total vs llama same-run 1540/92.8 — within noise of the close. Confirms the flag/kernel/replay removals did not regress Metal. No historical numbers changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small benchmark-doc cleanup — no code changes.
What
GEIST_WEIGHT_MMAP=1from three benchmark command lines (BENCHMARK_PI5.md,compare_ternary_pi5.sh×2). It is already the runtime default (arch_state.c), so setting it was cargo-cult. The explanatory note that mmap-alias is the default (and why it matters on a 4 GB Pi) stays.TERNARY_BITNET.md: the i8-sketch speculative output head is now default-on for greedy decode on an eligible tied lm_head (spec_head.c), not "opt-in; default off".Deliberately left alone
GEIST_WEIGHT_MMAP=1as the default.compare_metal.sh'sGEIST_M_MAX=${…:-128}— a real tuning knob with a fallback, not redundant.