Skip to content

Feature/index existing - #3

Closed
YoSiJo wants to merge 10 commits into
gekap:masterfrom
YoSiJo:feature/index-existing
Closed

Feature/index existing#3
YoSiJo wants to merge 10 commits into
gekap:masterfrom
YoSiJo:feature/index-existing

Conversation

@YoSiJo

@YoSiJo YoSiJo commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Yes, this is VipeCoded, where I tried to learn through more and more Python and looked at the points and tested them.
As far as I can see, and as far as the tests were concerned, this should correspond to my objective and be beneficial to the project here.

The whole thing should cover the case if you already have an existing file system, with many duplicates.
I have deliberately divided it into two options, because the goal of the fastest possible copying should be beneficial, while the second offers an added value from the hash effort.

--index-existing

This implements a scan of the target, but only the size of the data.
If the program does not find a hash when executing a file, it still checks whether it finds a file in the existing files with the same size and hashes it until it has found one with the matching hash, i.e. all of them.
A hashed file simply transfers it into the known table.

--dedup-existing

This is a small extra function that comes into play when a file hashed because it was the same size in the target and is therefore transferred from one table to the other.
He now checks whether the hash has already occurred in the table and then applies if necessary. FIDEDUPERANGE Deposits.

Ps. I would understand if the VipeCoding topic were a reason for rejection, but I also wanted to not lose the idea approach and at least bring the MR to the project.

@gekap

gekap commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Hello YoSiJo,

Thank you for your input. I will check it will you have commit so far

@gekap

gekap commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Hello YoSiJo,

Your idea is cool, I like it and there is something that I have not think of it. To be honest with you I cover it partially, but not fully as your suggestion. I run tests in CLI and GUI for bugs or any breaks, tests, and I will ship it in the next release.

Thank you,
George

@gekap gekap closed this Jul 8, 2026
@gekap

gekap commented Jul 8, 2026

Copy link
Copy Markdown
Owner

added to new version

@gekap

gekap commented Jul 29, 2026

Copy link
Copy Markdown
Owner

@YoSiJo — belated but deserved: --index-existing / --dedup-existing shipped in v3.12.3, and the design started with this PR. I've added a credit to the release notes. I should have said this properly when it shipped — thank you for the idea, the prototype, and the write-up. 🙏

gekap added a commit that referenced this pull request Jul 29, 2026
gekap added a commit that referenced this pull request Jul 29, 2026
…x-existing / --dedup-existing contribution (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants