Add ability to specify epistemic uncertainties on site model using ModifiableGMPE - #11650
Closed
CB-quakemodel wants to merge 7 commits into
Closed
Add ability to specify epistemic uncertainties on site model using ModifiableGMPE#11650CB-quakemodel wants to merge 7 commits into
CB-quakemodel wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A conceptually simple way of applying epistemic uncertainties on the site model parameters is to incorporate them within the GMM logic tree (i.e., same GMM, but different site params per branch of the GMM logic tree, with weight per branch needing to represent the product of GMM weight and site parameter weight).
This PR permits this through the use of ModifiableGMPE to simply update the site model params to those of given branch and then run the regular compute method on the underlying GMPE. We can expand (or potentially add more complex adjustments) as required in future site-specific projects too.
I add a QA test (classical/case_46) and some simple unit tests.